Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more remote types in use_dev_package. #1071

Merged
merged 6 commits into from
Mar 20, 2020
Merged

Support more remote types in use_dev_package. #1071

merged 6 commits into from
Mar 20, 2020

Conversation

antoine-sachet
Copy link
Contributor

@antoine-sachet antoine-sachet commented Mar 19, 2020 •
edited

Any remote of the form 'type::username/repo' is now supported by use_dev_package. Close #970.

The internal function package_remote only checks that the RemoteType, RemoteUsername and RemoteRepo are non-NA scalar string.

This means:

  • All standard remotes like bitbucket, gitlab, etc will work just fine.
  • Github remotes will now be prefixed by github:: in the DESCRIPTION
  • As requested, github remotes will not get the github:: prefix, in line with the existing behaviour.

@antoine-sachet
Support more remote types in use_dev_package.
7fd9223 
Remote must be of the form 'type::username/repo'. Close #970.
@antoine-sachet
Update NEWS
ca722c7
hadley
hadley reviewed Mar 19, 2020
View reviewed changes
R/package.R Outdated Show resolved Hide resolved
@hadley hadley merged commit 4d4d16d into r-lib:master Mar 20, 2020
@hadley
Copy link
Member

hadley commented Mar 20, 2020

Thanks @antoine-sachet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use_dev_package should handle more remote types
2 participants
@antoine-sachet @hadley