Explore setting RStudio prefs with rstudioapi #1733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
reviewed
Jan 18, 2023
| } | ||
|
|
||
| if (!is_rstudio_project()) { | ||
| ui_stop("{ui_value(project_name())} is not an RStudio Project.") | ||
| new <- list(...) |
There was a problem hiding this comment.
I expected to see list2() here re: dynamic dots.
| ui_stop("{ui_value(project_name())} is not an RStudio Project.") | ||
| new <- list(...) | ||
| if (!is_named(new)) { | ||
| cli::cli_abort("All arguments in ... must be named") |
There was a problem hiding this comment.
Suggested change
| cli::cli_abort("All arguments in ... must be named") | |
| cli::cli_abort("All arguments in `...` must be named") |
| expect_equal(prefs[["save_workspace"]], "never") | ||
| expect_false(prefs[["load_workspace"]]) | ||
| test_that("use_rstudio_config() can get and set prefs", { | ||
| use_rstudio_config(custom_pref = 10) |
There was a problem hiding this comment.
Yes — this is why this is draft PR and I did not request any reviews 😉
There was a problem hiding this comment.
Oh, sorry, I thought you did. I was just responding to a notification like a robot.
|
Taking a fresh stab at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1518