-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add edit_r_buildignore(); closes #231 #462
Conversation
R/edit.R
Outdated
#' @rdname edit | ||
edit_r_buildignore <- function(scope = c("user", "project")) { | ||
file <- edit_file(scoped_path_r(scope, ".Rbuildignore")) | ||
todo("Restart R for changes to take effect") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restarting R doesn't have any impact here, so can you please remove?
tests/testthat/test-edit.R
Outdated
@@ -68,6 +72,16 @@ test_that("edit_r_profile() ensures .Rprofile exists in project", { | |||
expect_proj_file(".Rprofile") | |||
}) | |||
|
|||
test_that("edit_r_buildignore() ensures .Rbuildignore exists in project", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you're effectively just testing edit_file()
, so I think you can remove the test.
I've incorporated your suggestions and rebased to get rid of the merge conflict in |
NEWS.md
Outdated
@@ -1,5 +1,7 @@ | |||
# usethis *development version* | |||
|
|||
* `edit_r_buildignore()` is added (#231, #462, @bfgray3). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `edit_r_buildignore()` is added (#231, #462, @bfgray3). | |
* `edit_r_buildignore()` is added (#231, @bfgray3). |
Thanks! |
No description provided.