add edit_r_buildignore(); closes #231#462
Merged
hadley merged 3 commits intor-lib:masterfrom Nov 26, 2018
bfgray3:edit_r_buildignore
Merged
add edit_r_buildignore(); closes #231#462hadley merged 3 commits intor-lib:masterfrom bfgray3:edit_r_buildignore
hadley merged 3 commits intor-lib:masterfrom
bfgray3:edit_r_buildignore
Conversation
hadley
reviewed
Nov 25, 2018
| #' @rdname edit | ||
| edit_r_buildignore <- function(scope = c("user", "project")) { | ||
| file <- edit_file(scoped_path_r(scope, ".Rbuildignore")) | ||
| todo("Restart R for changes to take effect") |
Member
There was a problem hiding this comment.
Restarting R doesn't have any impact here, so can you please remove?
| expect_proj_file(".Rprofile") | ||
| }) | ||
|
|
||
| test_that("edit_r_buildignore() ensures .Rbuildignore exists in project", { |
Member
There was a problem hiding this comment.
Here you're effectively just testing edit_file(), so I think you can remove the test.
Contributor
Author
|
I've incorporated your suggestions and rebased to get rid of the merge conflict in |
hadley
reviewed
Nov 26, 2018
| @@ -1,5 +1,7 @@ | |||
| # usethis *development version* | |||
|
|
|||
| * `edit_r_buildignore()` is added (#231, #462, @bfgray3). | |||
Member
There was a problem hiding this comment.
Suggested change
| * `edit_r_buildignore()` is added (#231, #462, @bfgray3). | |
| * `edit_r_buildignore()` is added (#231, @bfgray3). |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.