Fix protection issue in reduce-common-type counters #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
approved these changes
Apr 12, 2022
src/arg-counter.c
Outdated
| // finished. We protect those from upstack. | ||
| r_list_poke(shelter, COUNTERS_SHELTER_names, names); | ||
|
|
||
| struct counters_data* p_data = r_raw_begin(data_shelter); |
There was a problem hiding this comment.
Do you not get warnings about not being able to do this cast? Normally I have to this to avoid warnings:
struct counters_data* p_data = (struct counters_data*) r_raw_begin(data_shelter);There was a problem hiding this comment.
hmm I don't get any warnings with gcc or clang. I was under the impression that we can assign from void* to anything, e.g. with malloc()'s return pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes tidyverse/tidyr#1348.
I've tried to simplify the memory management a bit, but if we keep having issues in this area of the code, we should probably rewrite it in a simpler way.