Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: C++ Vctr class #31

Closed
wants to merge 26 commits into from
Closed

WIP: C++ Vctr class #31

wants to merge 26 commits into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 14, 2016

  • Currently implemented: logical, and a default class that forwards to base R (in inst/include/detail)
  • enum VctrTypes; one function get_type() that maps a given SEXP to an enum value, after that everything is done with template logic
  • Aimed towards extensibility, coercion logic specified via traits in inst/include/traits

PR branch: https://github.com/krlmlr/vctrs/tree/f-classes-draft

Currently a very rough draft, still missing:

  • tests
  • more elementary data types
  • factors
  • date/time
  • performance tests
  • a Vctr implementation that allows registration of Vctr classes at run time

@lionel-: Happy to take your feedback anytime.

Addresses #7 and #27.

@hadley
Copy link
Member

hadley commented Aug 6, 2018

I'm going to close this for now, since I think we have a better feel for how the implementation will work.

@hadley hadley closed this Aug 6, 2018
@krlmlr krlmlr deleted the f-classes-draft branch June 13, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants