Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict latin1 environment #202

Closed
edzer opened this issue Apr 11, 2019 · 7 comments
Closed

strict latin1 environment #202

edzer opened this issue Apr 11, 2019 · 7 comments

Comments

@edzer
Copy link
Member

edzer commented Apr 11, 2019

This message came from Brian Ripley (CRAN):

This concerns packages

CHNOSZ SARP.moodle caret dplyr fpeek fs gestalt hyphenatr incadata jpndistrict lobstr lucr pillar postGIStools rbison rchie rcmdcheck rcrossref rdatacite rerddap rgbif rplos skimr snakecase styler svglite swirl swirlify taxize testthat textTinyR traitdataform units urltools

which are failing their checks in a strict Latin-1 locale: see the debian-clang results. (Several of these seem to stem from vcr.)

On Linux, such a locale can be ensured via LC_CTYPE=en_US (which may need installing for distros that micro-package). AFAWK it cannot be done on Windows.

  1. The character in don't is an (ASCII) apostrophe, not a right quote:

don’t

(with a right quote) is used in packages CHNOSZ dplyr ptstem skimr styler text2vec textTinyR (and others not failing).

  1. en and em dashes are not portable, found in packages
    CHNOSZ SARP.moodle caret dplyr gestalt ptstem quanteda rchie rcrossref rdatacite rerddap rgbif rplos taxize textTinyR traitdataform units .

  2. Using \uxxxx coding for non-ASCII chars in R character strings should help in some cases (see 'Writing R Extensions').

Please correct before May 10 to safely retain the package on CRAN.

@Enchufa2
Copy link
Member

Strict latin1. Really? Ok, I'll have a look later. It seems to be the Celsius test. There's also a valgrind error, but that should be gone in the current development version.

@Enchufa2
Copy link
Member

The ERROR is reproducible for the CRAN version as follows:

LC_CTYPE=en_US R CMD check --as-cran units_0.6-2.tar.gz

The current development version passes the check cleanly, so you can just submit an update.

@Enchufa2
Copy link
Member

Enchufa2 commented May 2, 2019

Kind reminder. ;-)

@edzer
Copy link
Member Author

edzer commented May 3, 2019

On CRAN now!

@edzer edzer closed this as completed May 3, 2019
@Enchufa2
Copy link
Member

Enchufa2 commented May 5, 2019

We failed to notice this line... and thus it still fails on Debian. :(

@Enchufa2 Enchufa2 reopened this May 5, 2019
@Enchufa2
Copy link
Member

Enchufa2 commented May 5, 2019

Sorry for missing that; you'll probably hear from CRAN soon... Now it should work both on Debian with strict latin1 and on Windows.

Enchufa2 added a commit that referenced this issue Aug 21, 2019
@Enchufa2
Copy link
Member

I can't believe it... this is still ERRORing!? I was sure that the checks were successful. Maybe I used the wrong terminal? At least the test passes with ISO8859-1 for sure.

The only solution then is to skip the test...

edzer added a commit that referenced this issue Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants