Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export ud are convertible #263

Merged

Conversation

cregouby
Copy link
Contributor

and fix #258

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please see my comments.

NEWS.md Outdated Show resolved Hide resolved
R/udunits.R Show resolved Hide resolved
R/udunits.R Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #263 (84db29b) into master (3648766) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files          18       18           
  Lines         873      873           
=======================================
  Hits          823      823           
  Misses         50       50           
Impacted Files Coverage Δ
R/udunits.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3648766...84db29b. Read the comment docs.

@Enchufa2 Enchufa2 merged commit 67c608f into r-quantities:master Nov 28, 2020
@Enchufa2
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please export ud_are_convertible()
3 participants