Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vign basic: replace provider 'grass7' by 'grass' (anticipating QGIS 3.36) #207

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

florisvdh
Copy link
Member

@florisvdh florisvdh commented Feb 21, 2024

This is needed for the pkgdown site to build once QGIS 3.36 is released in the 'ubuntu' repo of QGIS. And to fix the vignette building in R-CMD-check at that time (already broken for ubuntu-nightly QGIS).

It also checks the minimum needed QGIS version to build this vignette, in order to prevent build errors with older QGIS versions.

  • Still to be added once QGIS 3.36 is available: updated build of README.

See qgis/QGIS#56196 for the related QGIS update; see OSGeo/grass#3047 for the referred QGIS-GRASS meeting minutes.

@florisvdh florisvdh marked this pull request as draft February 21, 2024 17:40
@florisvdh florisvdh changed the base branch from vign_updates to main February 22, 2024 08:22
@florisvdh florisvdh marked this pull request as ready for review February 26, 2024 13:15
@florisvdh florisvdh merged commit e3f83cd into main Feb 26, 2024
19 checks passed
@florisvdh florisvdh deleted the grass branch February 26, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant