[processing] Remove hardcoded v7 from grass provider, some fixes for v8 #56196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And transparently map requests for grass7 provider to grass provider It's misleading putting an old version number in the provider name, when this provider supports grass versions 8 +
lbartoletti
approved these changes
Feb 6, 2024
python/plugins/grassprovider/tests/testdata/grass_algorithms_imagery_tests.yaml
Show resolved
Hide resolved
|
Thanks, for taking this action! |
Merged
1 task
|
Cool! Confirmed with |
agiudiceandrea
added a commit
to agiudiceandrea/QGIS
that referenced
this pull request
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provider works with grass versions > 7, so hardcoding the older version name in is not appropriate.
Issue raised in GRASS GIS meeting, June 2023