Skip to content

Commit

Permalink
scoping x and y
Browse files Browse the repository at this point in the history
  • Loading branch information
edzer committed Jul 18, 2024
1 parent 0ef309a commit 84f3a3d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# version 1.0-17

* `st_filter.sf()` correctly scopes `x` and `y` arguments using !! operator

* `[.sfc` and `[<-.sfc` use matrix/array type subsetting for `sfc` objects that have a `dim` attribute

* add `st_exterior_ring()` to extract exterior rings (remove holes); #2406
Expand Down
2 changes: 1 addition & 1 deletion R/join.R
Original file line number Diff line number Diff line change
Expand Up @@ -189,5 +189,5 @@ st_filter.sf = function(x, y, ..., .predicate = st_intersects) {
if (!requireNamespace("dplyr", quietly = TRUE))
stop("dplyr is not installed: install first?")

dplyr::filter(x, lengths(.predicate(x, y, ...)) > 0) # will call filter.sf
dplyr::filter(x, lengths(.predicate(!!x, !!y, ...)) > 0) # will call filter.sf
}

0 comments on commit 84f3a3d

Please sign in to comment.