Add unnest method for sf class #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create unnest.sf method, automatically adding the geometry column(s) to the list of list columns that will *not* be unnested. - Add tests. - Increase suggested version of tidyr to > 0.7.2.
|
Update: this should work with the development version of tidyr now. |
edzer
reviewed
Nov 29, 2017
| nc = st_transform(nc[1:3,], 3857) | ||
| st_agr(nc) = "constant" | ||
| expect_is(nc, "tbl_df") | ||
| expect_is(st_intersection(nc[1:3], nc[4:6]), "tbl_df") | ||
| }) | ||
|
|
||
| test_that("unnest works", { |
There was a problem hiding this comment.
If you would make the test conditional on the tidyr version, it might pass tests and could be merged now.
edzer
reviewed
Nov 29, 2017
| RSQLite, | ||
| RPostgreSQL, | ||
| tibble, | ||
| rlang, | ||
| dplyr (>= 0.7-0), | ||
| tidyr (>= 0.7-1), | ||
| tidyr (> 0.7-2), |
|
Thanks! This is now ignored with CRAN versions; FYI I tried testing with tidyverse GH versions of tidyr, tidyselect and rlang, but that broke on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
.preserve. (Note, the CRAN and Github versions are both at 0.7.2, so the tests currently fail.)gather.sfandspread.sffor clearer expression (not part ofifblock).Do you want to hold off merging this until tidyr does a release?