Optimised Ops.sfc for simple cases #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… length 1 or purely diagonal matrices for *//
… in cpp code to avoid copying of structs
|
Great work, thanks! |
edzer
added a commit
that referenced
this pull request
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fast approach to
+,-,*,/when the rhs is a simple numeric that should get applied to each element in the list...for
+/-the new methods kicks in when rhs is of length 1 or 2, for*//it kicks in if rhs is of length one or a strictly diagonal matrixFurther this PR adds
st_normalizethat leverage the C++ code for even faster normalisation (avoids some copying by doing all the manipulation in one pass)