-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: update to GDAL 3.2.1 stack #1587
Conversation
@jeroen - good news! Some differences may be from the bundled EPSG database - it shifted from v9 to v10, so some textual changes are expected. May I make the same changes and checks for rgdal? Maybe also consider GEOS 3.9.0? |
@rsbivand yes you can do the same for rgdal. I have already tested it on my account here are the winbuilder results:
I wasn't aware there was a new version of geos. I can update it, but I am not sure if that means I also need to rebuild gdal, because it uses geos. |
OK I have triggered an update of geos and rebuilds of gdal/libspatialite, should be done later today. |
GEOS 3.9 changes to what they call the OverlayNG engine, which is more tolerant of input geometries in topological operations, so is worth the pain. I think we've sorted out all the packages expecting geometry components in output to be ordered the same as before - with OverlayNG, they are not, but the geometry collection is the same. |
Thanks @jeroen - the sf check diffs are noisy ATM, I need to clean them up, but I don't see anything unexpected. |
OK I have updated to GEOS 3.9.0 and rebuilt GDAL and spatialite against this new version. The PR above has been updated accordingly. For completeness, here are the new winbuilder checks: rgdal:
sf:
If that looks OK to you, this is ready to merge. You can make the same change in rgdal. |
Yes, looks good for rgdal; do you have similar rgeos output to exercise GEOS (not important, sf touches the same GEOS functions)? |
Fine, thanks. rgdal and rgeos ready to go to CRAN. I see that the GDAL 3 repo has been updated. |
I see you committed it. Windows and MacOS users will be able to install the latest binary packages from r-universe: install.packages("rgdal", repos = "https://r-forge.r-universe.dev") See also https://r-forge.r-universe.dev/ |
Thanks, @jeroen ! |
Fresh binaries with GDAL 3.2.1 and PROJ 7.2.1. Please do test, I think there are some breaking changes!
Update: I don't see any Windows CI here, but all tests have passed on Winbuilder! However I do see a lot of diff output in CMD check, would that be expected?