Add dialect argument for ExecuteSQL #1646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear
sf
developers, I created this PR to propose the inclusion of adialect
argument intost_read()
. The new argument can be used to choose the dialect used byExecuteSQL
. The idea for including a new parameter intost_read
started here. Still, I think that the possibility of selecting theSQLite
dialect can be useful in other contexts. Hence, I created some examples (taken from here) to present the new functionalities:Created on 2021-04-15 by the reprex package (v2.0.0)
I have minimal knowledge of C++/GDAL/GEOS/SQLite, so I'm not sure if I should add more tests, additional checks or implement a completely different approach. Anyway, if you agree, I could one example in ?st_read.