Tweak to ensure rwinlib compatibity with ucrt #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! I hope this will resolve the error stars currently has on UCRT when reading a netcdf file (it does this by calling GDAL routines in |
|
Yes I think it will. With this, the behaviour between the ucrt and non-ucrt builds should be consistent. |
|
Thanks Jeroen! I made the same tweak for rgeos rev 672 https://r-forge.r-project.org/scm/viewvc.php?root=rgeos&view=rev and rgdal rev 1135 https://r-forge.r-project.org/scm/viewvc.php?root=rgdal&view=rev. Does that make sense? |
|
Yes that looks correct, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweak for future compatibility.