Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revdep check failure #209

Closed
rsbivand opened this issue Nov 28, 2023 · 2 comments
Closed

Revdep check failure #209

rsbivand opened this issue Nov 28, 2023 · 2 comments

Comments

@rsbivand
Copy link

rsbivand commented Nov 28, 2023 •
edited

With forthcoming GDAL 3.8.1 and PROJ 9.3.1, and sf HEAD, test failures:
00check.log
testthat.Rout.zip

Error: processing vignette 'frequency.Rmd' failed with diagnostics: all(is.na(x)) is not TRUE

may be similar to alarm-redist/redist#175 @edzer? These two (so far) revdeps suggest that packages adding class names to sf objects (and using tibble?) go to default rather than sf, and mess up the agr values ?? 1.0-14 was published prior to r-spatial/sf@b301342 and subsequent. Are they rather sf issues?
@rsbivand rsbivand mentioned this issue Nov 28, 2023
Open
edzer added a commit to r-spatial/sf that referenced this issue Nov 28, 2023
@edzer
fix tidytransit st_agr() problem
6e7e571 
#2275
r-transit/tidytransit#209
@polettif
Copy link
Contributor

polettif commented Dec 4, 2023

Is there anything we need to do now on tidytransit?

@edzer
Copy link

edzer commented Dec 4, 2023

Fixing #210 would be great - I think that was the only issue left.

@polettif polettif closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@edzer @rsbivand @polettif