Add support for mounting .tgz files with filesystem metadata appended
#477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, use our own `mountImageData()` function to create VFS nodes for each file in the VFS metadata package. TODO: This currently handles only metadata given in the form of the `packages` property. Emscripten supports additional `files` and `blobs` properties, and in the future we should also support those here. Fixes #328.
georgestagg
force-pushed
the
tgz-mount
branch
from
2114dcc
to
68f209a
Compare
georgestagg
force-pushed
the
tgz-mount
branch
from
68f209a
to
93bc299
Compare
Also improves warning messaging during fallback(s).
georgestagg
commented
Sep 5, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new format is made the default when installing binary Wasm R packages.
Also fixes mounting filesystem images under Node, and so additional unit tests have been added for mounting both
.data/.js.metadataformatted packages from Emscripten'sfile_packagertool, and our own metadata appended.tarformat.Tagging @jeroen, for info.