Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Update to CMake 3.21.3 #229

Merged
merged 2 commits into from Oct 19, 2021
Merged

Update to CMake 3.21.3 #229

merged 2 commits into from Oct 19, 2021

Conversation

ihnorton
Copy link
Contributor

No description provided.

@jeroen jeroen merged commit ee1a9c5 into r-windows:master Oct 19, 2021
@jeroen
Copy link
Member

jeroen commented Oct 19, 2021

Thanks!

@ihnorton ihnorton deleted the ihn/patch-1 branch October 19, 2021 16:27
@jeroen
Copy link
Member

jeroen commented Oct 20, 2021

Btw, is there some feature that requires this version?

@ihnorton
Copy link
Contributor Author

We are considering bumping the minimum required cmake version to 3.21. There's no single feature, but these changes and others in the last few versions add up to a lot of usability improvements. The consideration is basically that if we are going to bump to 3.18, practically we might as well go to 3.21 b/c someone is always going to need to update. So I'm testing that out in our CI.

There are well-maintained cmake binaries on pypi now so IMO pinning to some ubuntu/debian LTS version isn't really necessary anymore (those wheels are built with manylinux2010 so they are compatible back to CentOS 6).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants