Replace escape_quotes
with json.dumps
in DOM.create_element
#1386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
escape_quotes
is inadequate here, as it will happily leave multiline strings as they are, which is a syntax error in javascript. It also doesn't seem to adequately deal with things like existing backslash escapes in the string.json.dumps
is guaranteed to produce valid json, which is also guaranteed to be a valid javascript data structure. By ensuring the type ofhtml
to bestr
, we guarantee that the output ofjson.dumps
will be a valid javascript string, properly quoted and escaped.