Fix CEF win resize hangs. https://github.com/r0x0r/pywebview/issues/484 #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0x0r
requested changes
Apr 23, 2020
| ``` bash | ||
| pip install pypiwin32 | ||
| ``` | ||
|
|
There was a problem hiding this comment.
pywin32 is not needed. You can use from ctypes import windll
webview/platforms/cef.py
Outdated
| self.initialized = True | ||
| self.loaded.set() | ||
|
|
||
| def close(self): | ||
| self.browser.CloseBrowser(True) | ||
|
|
||
| def resize(self, width, height): | ||
| win32gui.SetWindowPos(self.inner_hwnd, win32con.NULL, 0, 0, width - 16, height - 38, | ||
| win32con.SWP_NOZORDER | win32con.SWP_NOMOVE | win32con.SWP_NOACTIVATE) |
There was a problem hiding this comment.
It's strange but using ctypes.windll I got hangs when I randomly resize window by dragging it (but with much less chance than using cef.WindowUtils.OnSize). In the same case I got no hangs using win32gui during much longer test.
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
What's the status of this? I have a project that's kind of waiting for this fix. |
|
Merged. I have not tested it personally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary solution until cefpython release 66.1 version (after that
Browser.SetBoundsmethod will be available for Win and we should use it to resize window)