Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some small improvements for the Makefile.
The first commit fixes the dependencies for the "flash" and "size" targets. This is important since when running a parallel build (with, say,
make -j4
), if$(TARGET).elf
isn't built by the time$(SIZE) $(TARGET).elf
is run, the entire build will fail with the following error:After making that small change, the build never fails, no matter how many threads are used.
The second commit is more a matter of convenience, and allows you to specify your toolchain with the
CROSS_COMPILE
environment variable. The name is somewhat arbitrary--I just used the same name and semantics that the ARM Trusted Firmware-A project uses for specifying a toolchain.