Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture encoder in Encoded instead of the plain value #272

Closed
mp911de opened this issue Jun 23, 2023 · 0 comments
Closed

Capture encoder in Encoded instead of the plain value #272

mp911de opened this issue Jun 23, 2023 · 0 comments
Labels
type: enhancement A general enhancement
Milestone
1.0.2.RELEASE

Comments

@mp911de
Copy link
Member

mp911de commented Jun 23, 2023

We should capture a supplier that returns a byte buffer instead of the actual buffer to enable retries with bindings. Currently, the value is disposed after copying the encoded buffer to the request message. This prevents us from retrying RPC requests.

Prerequisite to fix #271
@mp911de mp911de added the type: enhancement A general enhancement label Jun 23, 2023
@mp911de mp911de added this to the 1.0.2.RELEASE milestone Jun 23, 2023
mp911de added a commit that referenced this issue Jun 23, 2023
@mp911de
Polishing.
7d5b08b 
[#272]

Signed-off-by: Mark Paluch <mpaluch@vmware.com>
mp911de added a commit that referenced this issue Jun 23, 2023
@mp911de
Capture encoder in Encoded instead of the plain value.
bfff9fe 
We now accept Suppliers to encode a value multiple times.

[resolves #272]

Signed-off-by: Mark Paluch <mpaluch@vmware.com>
mp911de added a commit that referenced this issue Jun 23, 2023
@mp911de
Polishing.
6d540a9 
[#272]

Signed-off-by: Mark Paluch <mpaluch@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.0.2.RELEASE
Development

No branches or pull requests
1 participant
@mp911de