Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chapter 10 #7

Merged
merged 4 commits into from
Aug 5, 2023
Merged

chapter 10 #7

merged 4 commits into from
Aug 5, 2023

Conversation

Fgazzelloni
Copy link
Contributor

No description provided.

jonthegeek
jonthegeek previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as it builds!

@jonthegeek jonthegeek enabled auto-merge (squash) July 18, 2023 12:24
@jonthegeek
Copy link
Member

@Fgazzelloni I lost track of this one, but it has an error:

Error in `select()`:
! unused arguments (SID74, BIR74, NWBIR74)
Backtrace:
 1. nc %>% select(SID74, BIR74, NWBIR74) %>% head
 2. utils::head(.)

Can you find and fix that error, and push the change? If you're not sure how to resume the PR, let me know!

auto-merge was automatically disabled August 4, 2023 20:24

Head branch was pushed to by a user without write access

@jonthegeek
Copy link
Member

@Fgazzelloni The problem is almost definitely that it's using the wrong "select". Did you library dplyr? if not, use dplyr::select

jonthegeek
jonthegeek previously approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this will do it!

jonthegeek
jonthegeek approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this doesn't do it, add "library(tidyverse)" to a block at the top of the doc. Thanks!

@jonthegeek jonthegeek enabled auto-merge (squash) August 5, 2023 13:18
@jonthegeek jonthegeek merged commit 64d9a66 into r4ds:main Aug 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonthegeek jonthegeek jonthegeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fgazzelloni @jonthegeek