Adding button with "reload" functionality. #1
Conversation
danoobae
commented
Aug 14, 2020
danoobae
commented
- Added button with "reload" functionality.
- Added testthat with the new button.
| #' Reload button with button and icon animations | ||
| #' | ||
| #' Animate a reloadButton and it's icon using | ||
| #' [Hover.css](https://github.com/IanLunn/Hover) |
There was a problem hiding this comment.
Since reloadButton isn't an actual button type from shiny, let's reword:
Animate a reload button and it's icon using Hover.css. Note that a reload button is just a
shiny::actionButtonwith onClick behavior to reload or refresh a web browser.
R/hover_reload_button.R
Outdated
| ) | ||
| } | ||
|
|
||
| validateIcon <- function (icon) { |
There was a problem hiding this comment.
validateIcon is now copied and pasted twice. Let's create a file utils.R, you can use usethis::use_r("utils"), then add validateIcon to the file.
| test_me <- hover_reload_button("id", "label") | ||
|
|
||
| # Test 1: attribs type is a button | ||
| expect_match( |
There was a problem hiding this comment.
I think expect_equal would be a better test to use in this example.
| ) | ||
|
|
||
| # Test 2: names on attribs list contains onClick | ||
| expect_match( |
There was a problem hiding this comment.
I think expect_true(any("onClick" %in% names(test_me$attribs))) would work well here.
| ) | ||
|
|
||
| # Test 3: Look for javascript command | ||
| expect_match( |
There was a problem hiding this comment.
I think expect_equal would be a better test in this example, expect_equal(test_me$attribs$onClick, "location.reload();").
| @@ -0,0 +1,33 @@ | |||
| context("Reload functionality") | |||
|
|
|||
| test_that("Test for three components in the button. Type is a 'button'.", | |||
There was a problem hiding this comment.
Let's reword to:
"hover_reload_button has expected structure"
FYI, I think the builds are failing because test_that is expecting a single vector for the description, e.g. the desc param.
| @@ -0,0 +1,33 @@ | |||
| context("Reload functionality") | |||
There was a problem hiding this comment.
Let's remove the context call, the tidyverse team has deprecated this function and actually discourages using it.
