Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update #3

Merged
merged 5 commits into from
Oct 6, 2020
Merged

Update #3

merged 5 commits into from
Oct 6, 2020

Conversation

ColinFay
Copy link
Contributor

@ColinFay ColinFay commented Oct 6, 2020

This PR implements several stuff:

  • useKey(), a more general way to bundle the dependencies
  • addKey(), to add a key binding from the server-side
  • removeKey(), to unbind from the server-side.

Feel free to cherry pick if you don't want them all.

@tylerlittlefield tylerlittlefield added enhancement New feature or request hacktoberfest Hacktoberfest! labels Oct 6, 2020
tylerlittlefield
tylerlittlefield reviewed Oct 6, 2020
View reviewed changes
Copy link
Member

@tylerlittlefield tylerlittlefield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you so much for these contributions, I am learning a lot from them. Before I merge, would you like to update the DESCRIPTION file to include yourself as an author? These seem to be pretty significant additions.

@tylerlittlefield tylerlittlefield removed enhancement New feature or request hacktoberfest Hacktoberfest! labels Oct 6, 2020
@tylerlittlefield tylerlittlefield mentioned this pull request Oct 6, 2020
Merged
@tylerlittlefield tylerlittlefield added enhancement New feature or request hacktoberfest Hacktoberfest! labels Oct 6, 2020
@ColinFay
Copy link
Contributor Author

ColinFay commented Oct 6, 2020

Sure, done ✅

@tylerlittlefield tylerlittlefield merged commit 5a37f2d into r4fun:master Oct 6, 2020
@tylerlittlefield
Copy link
Member

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerlittlefield tylerlittlefield tylerlittlefield left review comments

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest Hacktoberfest!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ColinFay @tylerlittlefield