This repository has been archived by the owner on Dec 4, 2019. It is now read-only.
Fix a bug of updating Build#incremental_id #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,7 +75,7 @@ def finish(result) | |||
| end | |||
|
|
|||
| def update_incremental_id | |||
| update_attributes(incremental_id: job.builds_count) | |||
| update_attributes(incremental_id: job.builds.count) | |||
There was a problem hiding this comment.
Thanks for your Pull-Request, but this change slows things down because it loses the benefit of counter cache.
I think what we should do for this problem are:
- Set a default value of jobs.build_count with 0 in a migration file
- Change incremental_id so that it starts with 1
There was a problem hiding this comment.
I'll fix this issue after merging your pull-request 👍
r7kamura
added a commit
that referenced
this pull request
Jul 24, 2013
Fix a bug of updating Build#incremental_id
|
🙇 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build#incremental_idshould be 1 at first but nil actually now.In this PR I fixed it.