This repository has been archived by the owner on Dec 4, 2019. It is now read-only.
Set build output and status before after executes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm making altria-ikachan plugin now. I'd like to change the message depending on the result of the build like this. https://github.com/mizzy/altria-ikachan/blob/master/lib/altria/ikachan/notifier.rb#L18
Because of chages of a153d78, spec/models/job_spec.rb fails. Job#current_build returns builds that don't have finished_at. So if build.finished_at is set, current_build returns nil and spec fails.
In 9d1a92, I've made the change not to set started_at and finished at. But to have multiple builds, build must have finished_at attribute.
In the example "Job#run with script runs its job", Altria::Executer.execute returns nil and this example fails.So I've made this fix. (I don't know why Altria::Executer.execute returns nil.)
|
Thank you for your pull request! 👍 |
r7kamura
added a commit
that referenced
this pull request
Aug 26, 2013
…fter_executes Set build output and status before after executes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making altria-ikachan plugin now.
I'd like to change the message depending on the result of the build like this.
https://github.com/mizzy/altria-ikachan/blob/master/lib/altria/ikachan/notifier.rb#L18
So I'd like to set build.status attribute after job#execute_script.
Please check this pull request.
Thanks.