Skip to content
This repository has been archived by the owner on Dec 4, 2019. It is now read-only.

Set build output and status before after executes #9

Commits on Aug 25, 2013

  1. Set build output and status before after_executes

    I'm making altria-ikachan plugin now.
    
    I'd like to change the message depending on the result of the build like this.
    https://github.com/mizzy/altria-ikachan/blob/master/lib/altria/ikachan/notifier.rb#L18
    mizzy committed Aug 25, 2013
    Copy the full SHA
    a153d78 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2013

  1. Don't set build.started_at and build.finished_at as default

    Because of chages of a153d78, spec/models/job_spec.rb fails.
    
    Job#current_build returns builds that don't have finished_at.
    So if build.finished_at is set, current_build returns nil and spec fails.
    mizzy committed Aug 26, 2013
    Copy the full SHA
    a9d1a92 View commit details
    Browse the repository at this point in the history
  2. Set build.finished_at to have multiple builds

    In 9d1a92, I've made the change not to set started_at and finished at.
    But to have multiple builds, build must have finished_at attribute.
    mizzy committed Aug 26, 2013
    Copy the full SHA
    c68ba4f View commit details
    Browse the repository at this point in the history
  3. Return if Altria::Executer.execute returns nil

    In the example "Job#run with script runs its job", Altria::Executer.execute returns
    nil and this example fails.So I've made this fix.
    (I don't know why Altria::Executer.execute returns nil.)
    mizzy committed Aug 26, 2013
    Copy the full SHA
    f6a4d95 View commit details
    Browse the repository at this point in the history