Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the full context label array made by PyOpenJTalk correctly in HTS.load #74

Merged
merged 1 commit into from
Nov 22, 2018

Conversation

Hiroshiba
Copy link
Contributor

@Hiroshiba Hiroshiba commented Nov 21, 2018

I think hts.io.load can take argument of the full context label string lines.

def load(self, path=None, lines=None):

This method eliminate the last character for deleting new line(in my understand).

cols = line[:-1].split()

But, lines may have nothing new lines. (for example, PyOpenJTalk).

This PR will resolve this problem.

Copy link
Owner

@r9y9 r9y9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@r9y9 r9y9 merged commit 1bc3ed3 into r9y9:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants