Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touchstone file not working. #392

Closed
4 tasks done
oe2lsp opened this issue Dec 4, 2023 · 12 comments · Fixed by #522
Closed
4 tasks done

touchstone file not working. #392

oe2lsp opened this issue Dec 4, 2023 · 12 comments · Fixed by #522
Labels
Milestone

Comments

@oe2lsp
Copy link

oe2lsp commented Dec 4, 2023

I either get an error massage or qucs-s terminates without any error message.

Qucs-s Version 2.1.0
Ngspice Version 41

two files attached:
terminate.zip
error.zip

Both touchstone files are working fine in qucs, the schematic files were created directly on qucs-s.
If there is any additional information needed, please let me know

TODO

Originally posted by @oe2lsp in #233 (comment)

@ra3xdh ra3xdh added the bug label Dec 4, 2023
@ra3xdh ra3xdh added this to the 24.1.0 milestone Dec 4, 2023
@ra3xdh
Copy link
Owner

ra3xdh commented Dec 4, 2023

qucs-s terminates without any error message

Yes, it's a bug. Thanks for reporting. I have just added a fix. The fix will be available since the next version. As a workaround you may remove the comment lines (starting with !) from the *.s2p files.

I either get an error message

The fix for s3p files will require some time. This files contains line continuation and the S-parameters list for every point is splitted to several lines. The original s2spice utility cannot process such files. On the other hand Ngspice doesn't support the S-parameters simulation if the port number is not equal two. You may convert this file if you combine the lines, but the 3-port S-parameter simulation will not work. You have to use Qucsator for such schematic.

@oe2lsp
Copy link
Author

oe2lsp commented Dec 4, 2023

thanks so far

@tomhajjar
Copy link

tomhajjar commented Dec 4, 2023

I found another issue. I edited the BFP780 s2p file to remove the comments but the test data is wrong. s11... s22 is always 0.5.

All my prior testing was done using Spice files converted from S-parameter files via s-spice.exe. I really didn't test any S-parameter files directly with the new Qucs-S version.

Updated Zip to include testing using S-parameter file converted by s-spice for comparison.

2023-12-04_114258

2023-12-04_114032

BFP780_test_prj.zip

@ra3xdh
Copy link
Owner

ra3xdh commented Dec 4, 2023

I edited the BFP780 s2p file to remove the comments but the test data is wrong

This file uses Mag/Angle format instead of Re/Im. This is not supported by Qucs-S converter and will not work. I am not aware if such files are supported by any version of s2spice utility. Qucsator supports both MA and RI formats.

@tomhajjar
Copy link

The vast majority of manufacturer supplied S-parameter files use Mag/Angle. I would think s2spice support most formats.

@ra3xdh
Copy link
Owner

ra3xdh commented Dec 4, 2023

I will add the support for MA format in future versions. Please wait. I have updated TODO list.

zergud added a commit that referenced this issue Dec 4, 2023
zergud added a commit that referenced this issue Dec 4, 2023
@zergud
Copy link
Collaborator

zergud commented Dec 4, 2023

please try current branch

@ra3xdh
Copy link
Owner

ra3xdh commented Dec 4, 2023

@zergud , Yes, now it is fixed.

ra3xdh added a commit that referenced this issue Dec 4, 2023
@ra3xdh
Copy link
Owner

ra3xdh commented Dec 4, 2023

Need to check everything according touchstone syntax guide: https://ibis.org/touchstone_ver2.0/touchstone_ver2_0.pdf

@tomhajjar
Copy link

Can I get a Windows 64 version to continue testing? I have lot's of Qucs S-parameters test projects for comparison and s2spice.exe.

@ra3xdh
Copy link
Owner

ra3xdh commented Dec 4, 2023

I will try to prepare a demo package in this week.

@ra3xdh
Copy link
Owner

ra3xdh commented Feb 2, 2024

The line continuation processing fixed by #522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants