Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new component that allows user to specify .spiceinit contents. #26

Merged
merged 5 commits into from
Jun 23, 2019

Conversation

spueblas
Copy link
Contributor

@spueblas spueblas commented Jun 21, 2019

Adds a new SPICE-only component (SPICEINIT), that users can use to specify .spiceinit contents. For this component, a new dialog was created, which allows editing a single text box (used in this case for the contents of the spiceinit file), and could potentially be reused for other purposes.

The new component, SPICEINIT, is only used in the ngspice simulator class. Other simulators, like Xyce, ignore this new component. For ngspice simulator, the specified contents of spiceinit are forwarded to the XSPICE_CMbuilder class, which is currently in charge of creating the spiceinit file. This is a bit unfortunate, as it would be cleaner if the responsibility of creating spiceinit was kept by Ngspice class.

Still to do, create an icon for the new component as it currently is reusing sp_options.png. BTW, how do you create those icons? I'm afraid if I try to do it manually with GIMP or something it will not look the same style as the other icons.

Screenshot displaying how it shows in the component selector and the schematics:
Screenshot from 2019-06-21 17-09-53
Fixes #25

@ra3xdh
Copy link
Owner

ra3xdh commented Jun 23, 2019

Looks good, surely it could be useful. I will try to test it in the next days.

@ra3xdh ra3xdh added this to the 0.0.22 milestone Jun 23, 2019
@ra3xdh
Copy link
Owner

ra3xdh commented Jun 23, 2019

BTW, how do you create those icons?

I open an exisitng icon with KolorPaint or another such software and edit it. Yes can use .OPTIONS icon and replace the text. GIMP is overkill for such task.

@spueblas
Copy link
Contributor Author

Added an icon for the new component. PTAL.

@ra3xdh
Copy link
Owner

ra3xdh commented Jun 23, 2019

I have tested it. The XSPICE compatibility seems not to be broken. I have found no further problems with the new component.

@ra3xdh
Copy link
Owner

ra3xdh commented Jun 23, 2019

Are you planning to add some new features for this .spinit device? Otherwise I will merge this PR.

@ra3xdh ra3xdh self-requested a review June 23, 2019 18:07
@spueblas
Copy link
Contributor Author

I was not planning to add any new features for this new component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support specifying user-defined .spiceinit in the schematic.
2 participants