Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ideal.lib; fixes #258 #428

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

Radvall
Copy link
Contributor

@Radvall Radvall commented Jan 1, 2024

Added SPICE models for: BPF2, HPF1, Ideal, LPF1, Notch2, Diff, HPF2, Int, LPF2, VDelay provided by @tomhajjar in #258. Library order updated.

I don't find new OpAmp model so I fix existed SPICE model and rebuilt ABS, AP1, AP2, Quantizer and Limiter models, now it should works in ngspice.

The table below shows summary results of testing ideal.lib after the changes were made.

Component qucsator ngspice
VSum
VSub
Mul
Div
Sqrt
Int
Dif
Abs
VDelay
VCO
Quantizer
OpAmp
Limiter
HardLimiter
LP1
LP2
HP1
HP2
BP1
Notch2
AP1
AP2

For testing I used Qucsator 0.0.20 and ngspice-41. Simulation project for testing attached

Ideal_Library_Models_Test_prj.tar.gz
Ideal_Library_Test_prj.tar.gz

Voltage Controlled Oscillator subcircuit contains phase modulated source which is missing in ngspice. So I don't know how implement in QUCS-S.

Simulation results for ABS, AP1, AP2, Quantizer, HardLimiter, Limiter and OpAmp are shown bellow:

abs_qucs

ap1_qucs

ap2_qucs

hardlimiter_qucs

limiter_qucs

opamp_qucs

quantizer_qucs

@tomhajjar
Copy link

tomhajjar commented Jan 2, 2024 via email

@Radvall
Copy link
Contributor Author

Radvall commented Jan 2, 2024

Sergei Your work looks good. I incorporated your work and fixed Sum, Div and Sqrt. Attached are the two projects. The new Ideal.lib is in both projects. Ideal_Library_projects.zip

Thanks @tomhajjar you did a great job! I added the missing models, now only VCO doesn't work with ngspice

@ra3xdh ra3xdh added the library label Jan 2, 2024
@ra3xdh ra3xdh added this to the 24.1.0 milestone Jan 2, 2024
@ra3xdh ra3xdh changed the title Fix ideal.lib Fix ideal.lib; fixes #258 Jan 2, 2024
@ra3xdh ra3xdh merged commit 12be148 into ra3xdh:current Jan 2, 2024
2 checks passed
@ra3xdh
Copy link
Owner

ra3xdh commented Jan 2, 2024

Thanks for contribution! Merged.

@tomhajjar
Copy link

tomhajjar commented Jan 2, 2024

Diff never worked in Qucs or QucsStudio.

Here is Ideal.lib with VCO at the end.

Ideal-lib.zip

@Radvall Radvall deleted the fix_ideal_library branch January 2, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants