Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
If merged this PR would add the ability to scroll schematic by moving mouse with middle button pressed down:
panning.webm
It also introduces a change that I'm not quite sure about: I had to delete
setHidden(true)
andsetHidden(false)
before and afterresizeContents
inrenderModel
method because theQ3ScrollView
contents widget didn't receive MouseMove events after hiding and then unhiding the widget. I haven't observed any differences after removing these lines though. May be they don't make any sense now (they were inherited from legacy implementation) and it's OK to remove them.