Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpiceLibComp redesign #755

Merged
merged 16 commits into from
Jun 15, 2024
Merged

SpiceLibComp redesign #755

merged 16 commits into from
Jun 15, 2024

Conversation

ra3xdh
Copy link
Owner

@ra3xdh ra3xdh commented Jun 12, 2024

This PR contains a redesign of the SpiceLibComp as discussed in #679. The following features are implemented:

  • Custom dialog for SpiceLibComp
  • Custom pin assignment using pin table
  • Symbol preview
  • SPICE code preview

Here is a screenshot illustrating a new custom dialog:
image

Here is a video illustrating pins assignment process:

Screencast_20240612_191828.webm

@ra3xdh ra3xdh added this to the 24.3.0 milestone Jun 12, 2024
@ra3xdh ra3xdh linked an issue Jun 12, 2024 that may be closed by this pull request
7 tasks
@ra3xdh ra3xdh mentioned this pull request Jun 12, 2024
7 tasks
@ra3xdh ra3xdh marked this pull request as draft June 12, 2024 16:43
@ra3xdh
Copy link
Owner Author

ra3xdh commented Jun 13, 2024

Rebased against current and force pushed after merging #754

@ra3xdh
Copy link
Owner Author

ra3xdh commented Jun 14, 2024

I have rearranged controls and added possibility to specify the symbol file. Your feedback is appreciated.
image

@ra3xdh ra3xdh marked this pull request as ready for review June 14, 2024 17:04
@ra3xdh ra3xdh merged commit 0a63baf into current Jun 15, 2024
7 checks passed
@ra3xdh
Copy link
Owner Author

ra3xdh commented Jun 15, 2024

I have merged this. I will prepare a separate PR if something in the new SpiceLibComp will need a correction.

@ra3xdh ra3xdh deleted the 679_new_spicelibcomp branch July 4, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SpiceLibComp device
1 participant