Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 404 page, closes #51 #269

Merged
merged 6 commits into from
May 19, 2021
Merged

fix: 404 page, closes #51 #269

merged 6 commits into from
May 19, 2021

Conversation

olavea
Copy link
Collaborator

@olavea olavea commented May 11, 2021

No description provided.

@olavea olavea requested a review from raae May 11, 2021 07:45
@olavea olavea self-assigned this May 11, 2021
@olavea olavea changed the title fix: 404 page #51 (#268 ) fix: 404 page #51 May 11, 2021
@olavea
Copy link
Collaborator Author

olavea commented May 11, 2021

And when I merge I call the title

fix: 404 page #51 (#269 )

@olavea olavea linked an issue May 11, 2021 that may be closed by this pull request
Why is unknown pages not redirected to the gatsby 404 page #51
Closed
raae
raae requested changes May 11, 2021
View reviewed changes
Copy link
Owner

@raae raae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing out https://conventionalcomments.org/ when reviewing.

src/pages/404.js Outdated Show resolved Hide resolved
src/pages/404.js Outdated Show resolved Hide resolved
src/pages/404.js Outdated Show resolved Hide resolved
src/pages/404.js Outdated Show resolved Hide resolved
src/pages/404.js Outdated Show resolved Hide resolved
@raae raae mentioned this pull request May 11, 2021
Closed
raae
raae reviewed May 12, 2021
View reviewed changes
src/pages/404.js Outdated Show resolved Hide resolved
raae
raae requested changes May 13, 2021
View reviewed changes
src/pages/404.js Outdated Show resolved Hide resolved
@raae
Copy link
Owner

raae commented May 15, 2021

Use the photo and copy in this comment: #269 (comment)
You can push both to this branch and I will approve 🎉

@raae raae mentioned this pull request May 15, 2021
Closed
@olavea
Copy link
Collaborator Author

olavea commented May 17, 2021

Use the photo and copy in this comment: #269 (comment)
You can push both to this branch and I will approve 🎉

It's done 😺 👍
The code is here

@olavea
Copy link
Collaborator Author

olavea commented May 17, 2021

Question 1
When I merge, should I write:

"fix: 404 page #51 (#269)" here?

365DaysOfPOWprogramming-day-131-_coomit _👈😜-#-342

Question 2
Should I not update branch first?
365DaysOfPOWprogramming-day-137_fix- 404 page #51 (#269 ) update branche first-#-350

@raae
Copy link
Owner

raae commented May 17, 2021

Yes you should, then squash.

raae
raae approved these changes May 17, 2021
View reviewed changes
Copy link
Owner

@raae raae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll move the image into our src. as a separate task. Make it an issue.

@raae raae changed the title fix: 404 page #51 fix: 404 page, closes #51 May 18, 2021
@olavea olavea merged commit bfddec5 into main May 19, 2021
@olavea
Copy link
Collaborator Author

olavea commented May 19, 2021

Please don't delete this branch I am working on my notes
😸
365DaysOfPOWprogramming-day-139_fix-404_page_#51_(#269 )_don't_delete_branch-#-352

@raae raae linked an issue May 30, 2021 that may be closed by this pull request
Add an image to the 404.js page #272
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raae raae raae approved these changes

Assignees

@olavea olavea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an image to the 404.js page Why is unknown pages not redirected to the gatsby 404 page
2 participants
@olavea @raae