Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clog-db-table doesn't place td elements inside rows #314

Closed
raineszm opened this issue Oct 20, 2023 · 1 comment
Closed

clog-db-table doesn't place td elements inside rows #314

raineszm opened this issue Oct 20, 2023 · 1 comment

Comments

@raineszm
Copy link

raineszm commented Oct 20, 2023

The next-row method on clog-db-table generates html like

<tr></tr>
<td>col1</td><td>col2</td>

Probably this should be

<tr><td>col1</td><td>col2</td></tr>

This can be fixed with the change

diff --git a/source/clog-dbi.lisp b/source/clog-dbi.lisp
index d18557f..6e2c5ed 100644
--- a/source/clog-dbi.lisp
+++ b/source/clog-dbi.lisp
@@ -427,7 +427,7 @@ the displayed option."
           (funcall (on-row obj) obj tr))
         (loop for (key value) on row by #'cddr while value
               do
-                 (let ((td (create-table-column obj :content value)))
+                 (let ((td (create-table-column tr :content value)))
                    (when (on-column obj)
                      (funcall (on-column obj) obj key td)))))))
   (when (on-footer obj)

Happy to submit a PR if that's easier, and thanks for the wonderful tool.

rabbibotton added a commit that referenced this issue Jan 15, 2024
@rabbibotton
Copy link
Owner

done, sorry for delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants