Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates ['rabbitmq']['config'] to use ['rabbitmq']['config_root'] attribute #172

Merged
merged 1 commit into from Dec 2, 2014

Conversation

Projects
None yet
3 participants
@wenchma
Copy link
Contributor

commented Dec 1, 2014

Attribute ['rabbitmq']['config'] should not be hard coding again.
Cover the following two lines:
https://github.com/jjasghar/rabbitmq/blob/master/attributes/default.rb#L19
https://github.com/jjasghar/rabbitmq/blob/master/attributes/default.rb#L89

Fixes issue #155

wenchma
@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Dec 1, 2014

Looks good to me 👍

@jjasghar

This comment has been minimized.

Copy link
Collaborator

commented Dec 2, 2014

@michaelklishin can i get a 👍 on this? 😁

@michaelklishin

This comment has been minimized.

Copy link
Member

commented Dec 2, 2014

@jjasghar LGTM, 👍.

jjasghar pushed a commit that referenced this pull request Dec 2, 2014

JJ Asghar
Merge pull request #172 from wenchma/issue#155
Updates ['rabbitmq']['config'] to use ['rabbitmq']['config_root'] attribute

@jjasghar jjasghar merged commit 4192075 into rabbitmq:master Dec 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.