Make tcp listeners optional #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A better name for this attribute would be |
|
Just checking-in on this one. Anyone willing to merge this? I would be happy to rename that attr if necessary. |
|
Will this be merged? |
|
Many users who use TLS also disable non-TLS connections, so this makes a lot of sense. |
|
+1 for this request! Since this update affects only a few lines I wouldn't mind creating a re-request without merge conflicts if that's the issue ;-) |
|
@ziuchkovski @frankwis rebasing this on master would be much appreciated. thanks! |
frankwis
pushed a commit
to frankwis/rabbitmq
that referenced
this pull request
Oct 10, 2014
Re-implementing tcp listener pull request by ziuchkovski (rabbitmq#89)
|
merged PR #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the tcp listeners optional. This is useful when all rabbit connections should be made over SSL.