Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top level getConsumers methods #242

Closed
jschabowsky opened this issue Jun 26, 2021 · 1 comment
Closed

Add top level getConsumers methods #242

jschabowsky opened this issue Jun 26, 2021 · 1 comment
Milestone
3.11.0

Comments

@jschabowsky
Copy link
Contributor

While using the API I realized that a call to api/consumers returns valuable information that is not available (that I could find) within the API. I cloned the repo and added:
public List getConsumers()
public Page getConsumers(QueryParameters queryParameters)
public ConsumerDetails getConsumer(String name)

I would be happy to do a pull request if you agree this is a good idea! Thanks for your consideration!
@michaelklishin
Copy link
Member

Listing all consumers is rarely really necessary but I have no objections.
Please submit a PR?

@jschabowsky jschabowsky mentioned this issue Jun 28, 2021
Merged
@acogoluegnes acogoluegnes added this to the 3.11.0 milestone Jun 29, 2021
acogoluegnes added a commit that referenced this issue Jun 30, 2021
@acogoluegnes
Remove Client#getConsumers(QueryParameters)
37456f7 
The /consumers endpoint does not support pagination parameters.

References #242
acogoluegnes added a commit that referenced this issue Jun 30, 2021
@acogoluegnes
Add consumers method to reactive client
0daa39b 
References #242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

No branches or pull requests
3 participants
@michaelklishin @acogoluegnes @jschabowsky