Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding delete panic #559

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Binding delete panic #559

merged 2 commits into from
Feb 23, 2023

Conversation

ChunyiLyu
Copy link
Contributor

This closes #555

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes

Summary Of Changes

Use latest rabbithole that contains this fix: michaelklishin/rabbit-hole#253.
Before the fix, when destinationType is not provided, rabbithole used to panic and crash the operator when DeleteBinding() is called.
Now when deleting a binding.rabbitmq.com with no destinationType set, operator reconciles successfully:

2023-02-23T13:03:42Z	DEBUG	events	failed to declare binding	{"type": "Warning", "object": {"kind":"Binding","namespace":"rabbitmq-system","name":"bunny","uid":"8e1cb60c-5d7f-45b1-aad3-4653166ca9cd","apiVersion":"rabbitmq.com/v1beta1","resourceVersion":"706670"}, "reason": "FailedDeclare"}
2023-02-23T13:03:42Z	ERROR	Reconciler error	{"controller": "binding", "controllerGroup": "rabbitmq.com", "controllerKind": "Binding", "Binding": {"name":"bunny","namespace":"rabbitmq-system"}, "namespace": "rabbitmq-system", "name": "bunny", "reconcileID": "304a7a48-799a-46a8-9f00-e395a8710d1f", "error": "Error 405 (Error 405 from RabbitMQ: EOF): "}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:274
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.4/pkg/internal/controller/controller.go:235
2023-02-23T13:03:46Z	INFO	Deleting	{"controller": "binding", "controllerGroup": "rabbitmq.com", "controllerKind": "Binding", "Binding": {"name":"bunny","namespace":"rabbitmq-system"}, "namespace": "rabbitmq-system", "name": "bunny", "reconcileID": "3b2df8fd-f9cd-4018-9b8c-c01c247a40bb"}
2023-02-23T13:03:46Z	INFO	cannot find binding in rabbitmq server; already deleted	{"controller": "binding", "controllerGroup": "rabbitmq.com", "controllerKind": "Binding", "Binding": {"name":"bunny","namespace":"rabbitmq-system"}, "namespace": "rabbitmq-system", "name": "bunny", "reconcileID": "3b2df8fd-f9cd-4018-9b8c-c01c247a40bb"}

Additional Context

@ChunyiLyu ChunyiLyu merged commit 95cef54 into main Feb 23, 2023
@ChunyiLyu ChunyiLyu deleted the binding-delete-panic branch February 23, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic on finalization of no-op binding CR
3 participants