This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
Re-include policies and parameters in rabbitmqctl report & reduce code footprint on aliases #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayanda-D
force-pushed
the
include-policies-and-parameters-to-report
branch
from
7354d3c
to
d4617a5
Compare
Ayanda-D
changed the title
lukebakken
approved these changes
Jul 31, 2018
There was a problem hiding this comment.
Just today I was wondering why this data isn't included in rabbitmqctl report and now I know why 😄 . Tested with RMQ 3.7.7 and Erlang 20.3.8.2 / Elixir 1.6.4
Since all the formatting changes are in their own commit I can review the change that actually matters ... but generally we prefer having large non-functional changes in their own PR.
michaelklishin
approved these changes
Jul 31, 2018
|
@Ayanda-D thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Policies and parameters have always been part of the
reportcommand in prior major releases.We still need them in captured
3.7.xreports.(Side note, elixir aliases fall to last part of trailing module name, without need for
as:. Just left this for consistency with entire CLI implementation, although unnecessary).