Continue to use direct exchange routing v1 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x-delayed-message exchange type does not use direct exchange routing v2 even when this feature flag is enabled. Therefore, route directly via rabbit_router:match_routing_key/2 which corresponds to "direct exchange routing v1". Fix failing tests against rabbitmq-server master branch. Fixes #199
ansd
force-pushed
the
no-direct-exchange-routing-v2
branch
from
5393a59
to
ab581d7
Compare
1 task
ansd
added a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Dec 13, 2022
Custom exchange types can use the direct exchange as a proxy for routing. However, custom exchange types should continue to use "direct exchange routing v1" because their bindings are not inserted into the new routing table `rabbit_index_route`. This commits avoids changing the custom exchange types to call `rabbit_router:match_routing_key/2` directly as done in rabbitmq/rabbitmq-delayed-message-exchange#200 and rabbitmq/rabbitmq-lvc-exchange#32 because other exchange types are out there (as we learnt in #4606 (comment)) which also need to continue to use v1. So, the cleaner approach is to only use direct exchange routing v2 if 1. the feature flag 'direct_exchange_routing_v2' is enabled, and 2. the source exchange is of type 'direct'
mergify bot
pushed a commit
to rabbitmq/rabbitmq-server
that referenced
this pull request
Dec 13, 2022
Custom exchange types can use the direct exchange as a proxy for routing. However, custom exchange types should continue to use "direct exchange routing v1" because their bindings are not inserted into the new routing table `rabbit_index_route`. This commits avoids changing the custom exchange types to call `rabbit_router:match_routing_key/2` directly as done in rabbitmq/rabbitmq-delayed-message-exchange#200 and rabbitmq/rabbitmq-lvc-exchange#32 because other exchange types are out there (as we learnt in #4606 (comment)) which also need to continue to use v1. So, the cleaner approach is to only use direct exchange routing v2 if 1. the feature flag 'direct_exchange_routing_v2' is enabled, and 2. the source exchange is of type 'direct' (cherry picked from commit a25eeb0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-delayed-message exchange type does not use direct exchange routing v2
even when this feature flag is enabled.
Therefore, route directly via rabbit_router:match_routing_key/2 which corresponds
to "direct exchange routing v1".
Fixes failing tests against rabbitmq-server master branch.
Similar to what's done in rabbitmq/rabbitmq-lvc-exchange#32.
Fixes #199