Track timer state to optimize message publication (stable branch) #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds explicit tracking for the case where no timer is set. In that case, the timer is assigned to the `not_set` atom. This allows us to distinguish between the cases where no timer is set and the case where the timer was set but has expired. Previously, the `internal_delay_message` function was unable to tell the difference between these two cases. This is a problem because the action it should take in either case is different. If the timer was never set, the enqueue code path must start one. If the timer has expired and will be processed soon, then starting a new timer would be a waste of time. The previous solution was to always start the timer, since that does not affect correctness. Now that we can distinguish the two scenarios, the enqueue path can handle each case independently. This makes enqueing significantly faster in the case where enqueuing coincides with messages becoming ready for delivery.
|
I don't understand the test failures. Let me know if there's something I can do to fix them. |
|
Thanks @richardlarocque |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracks the state of the timer so we can tell the difference between the timer being expired and the timer not being set. This allows us to avoid settings lots of redundant timers when publishing messages while other messages are reaching their delivery time.
This is a successor to #53, which was targeting the master branch.
That PR was a successor to #51, which contained a different approach for solving the same problem. See that issue and https://groups.google.com/forum/#!topic/rabbitmq-users/XgjY7UtLkfs for more information.