Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted order to avoid invalid warning about TrustEverythingTrustManager #75

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Adjusted order to avoid invalid warning about TrustEverythingTrustManager #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/rabbitmq/jms/admin/RMQConnectionFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@ protected Connection createConnection(String username, String password, Connecti
this.username = username;
this.password = password;
com.rabbitmq.client.ConnectionFactory cf = createConnectionFactory();
setRabbitUri(logger, this, cf, getUri());
maybeEnableTLS(cf);
setRabbitUri(logger, this, cf, getUri());
maybeEnableHostnameVerification(cf);
cf.setMetricsCollector(this.metricsCollector);

Expand Down Expand Up @@ -332,6 +332,7 @@ public void setUri(String uriString) throws JMSException {
if (uriString != null && !uriString.trim().isEmpty()) {
// Create a temp factory and set the properties by uri
com.rabbitmq.client.ConnectionFactory factory = createConnectionFactory();
// Generates a TrustEverythingTrustManager warning which can be ignored as the SSLContext is not copied over
setRabbitUri(logger, this, factory, uriString);
// Now extract our properties from this factory, leaving the rest unchanged.
this.host = factory.getHost();
Expand Down