Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RMQQueuingConnectionDelegateProxy retain cycle #206

Closed
541278903 opened this issue Aug 11, 2022 · 2 comments
Closed

RMQQueuingConnectionDelegateProxy retain cycle #206

541278903 opened this issue Aug 11, 2022 · 2 comments

Comments

@541278903
Copy link

"RMQQueuingConnectionDelegateProxy.h"

@Property (nonatomic, readwrite) id delegate;❌

@Property (nonatomic, readwrite, weak) id delegate; ✅
@michaelklishin michaelklishin transferred this issue from rabbitmq/rabbitmq-tutorials Aug 11, 2022
@michaelklishin
Copy link
Member

michaelklishin commented Aug 11, 2022 •
edited

@541278903 submitting an issue to the wrong repo without any details, data or evidence, and pointing to the wrong file ❌
Submitting to a pull request to the right repo with evidence from diagnostics tools ✅

@michaelklishin
Copy link
Member

Without further evidence I'd assume that this is a duplicate of #197.

@michaelklishin michaelklishin mentioned this issue Aug 11, 2022
Closed
michaelklishin added a commit that referenced this issue Aug 12, 2022
@michaelklishin
RMQQueuingConnectionDelegateProxy: made delegate reference weak
a635b10 
as suggested by @541278903 in #206, #207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelklishin @541278903