Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RMQQueuingConnectionDelegateProxy retain cycle #207

Closed
541278903 opened this issue Aug 11, 2022 · 3 comments
Closed

[RMQQueuingConnectionDelegateProxy retain cycle #207

541278903 opened this issue Aug 11, 2022 · 3 comments

Comments

@541278903
Copy link

in file "RMQQueuingConnectionDelegateProxy.h"

property id delegate need to use weak

use weak to fix retain cycle
@michaelklishin michaelklishin changed the title [ERROR] RMQQueuingConnectionDelegateProxy (retain cycle) [RMQQueuingConnectionDelegateProxy retain cycle Aug 11, 2022
@michaelklishin
Copy link
Member

Duplicate of #206. You again provided no evidence, filing duplicate issues will get you banned from this org.

@michaelklishin
Copy link
Member

@541278903 if you understand what the problem is, please submit a PR. This is open source software. I'd be happy to run all test suites for you.

Claims that "X has to do Y" leave maintainers guessing, and we do not guess on this team.

michaelklishin added a commit that referenced this issue Aug 12, 2022
@michaelklishin
RMQQueuingConnectionDelegateProxy: made delegate reference weak
a635b10 
as suggested by @541278903 in #206, #207
@541278903
Copy link
Author

OK，i will do better next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelklishin @541278903