-
Notifications
You must be signed in to change notification settings - Fork 84
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testConcurrentDeliveryOnDifferentChannels sporadic crash #56
Labels
Comments
camelpunch
changed the title
Concurrent delivery on different channels test sporadic crash
testConcurrentDeliveryOnDifferentChannels sporadic crash
Apr 28, 2016
Removing the heartbeat code makes this test pass reliably. We need to re-implement client heartbeats with a timer dispatch source |
It turns out this is a |
camelpunch
added a commit
that referenced
this issue
May 2, 2016
camelpunch
added a commit
that referenced
this issue
May 2, 2016
camelpunch
added a commit
that referenced
this issue
May 2, 2016
It turns out that changing the date property from nonatomic to atomic was the key to fixing Issue #56, but the timer source implementation is more efficient according to the Apple docs: https://developer.apple.com/library/mac/documentation/General/Conceptual/ConcurrencyProgrammingGuide/GCDWorkQueues/GCDWorkQueues.html#//apple_ref/doc/uid/TP40008091-CH103-SW2
camelpunch
added a commit
that referenced
this issue
May 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This usually happens during a semaphore wait, but that could be coincidental.
Possibly unrelated: increasing the channel count to 1000 produces some interesting errors.
Many of these:
Then many of these:
The above is probably #57
I suspect we're flooding the socket with writes and not handling reads in between.
The text was updated successfully, but these errors were encountered: