Skip to content
This repository has been archived by the owner on Nov 16, 2020. It is now read-only.

cluster_formation.peer_discovery_backend aliases #43

Closed
michaelklishin opened this issue Jun 2, 2020 · 1 comment · Fixed by #44
Closed

cluster_formation.peer_discovery_backend aliases #43

michaelklishin opened this issue Jun 2, 2020 · 1 comment · Fixed by #44
Assignees
@michaelklishin
Milestone
3.8.5

Comments

@michaelklishin
Copy link
Member

This plugin's name is rabbitmq_peer_discovery_consul but the module name that must be configured for discovery is

cluster_formation.peer_discovery_backend = rabbit_peer_discovery_consul

which confuses some users and leads to hours spent troubleshooting and a lot of frustration.

We should introduce an alias module and consider an alias shortcut supported in rabbitmq.conf so that these config values

cluster_formation.peer_discovery_backend = rabbitmq_peer_discovery_consul
cluster_formation.peer_discovery_backend = consul

would be accepted.
@michaelklishin michaelklishin added this to the 3.8.5 milestone Jun 2, 2020
@michaelklishin michaelklishin self-assigned this Jun 2, 2020
michaelklishin added a commit that referenced this issue Jun 2, 2020
@michaelklishin
Alias rabbit_peer_discovery_consul as rabbitmq_peer_discovery_consul
b585d99 
So that if someone assumes that the discovery module name is the same
as plugin name, they don't have to troubleshoot `undef' exceptions.

Closes #43
@michaelklishin michaelklishin mentioned this issue Jun 2, 2020
Merged
michaelklishin added a commit that referenced this issue Jun 2, 2020
@michaelklishin
Alias rabbit_peer_discovery_consul as rabbitmq_peer_discovery_consul
7e49a9a 
So that if someone assumes that the discovery module name is the same
as plugin name, they don't have to troubleshoot `undef' exceptions.

Closes #43
@michaelklishin
Copy link
Member Author

FTR, short names have been supported since 3.7.0: rabbitmq/rabbitmq-server@5f9752c, rabbitmq/rabbitmq-server@245e3c7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michaelklishin michaelklishin

Labels
None yet
Projects
None yet
Milestone
3.8.5
1 participant
@michaelklishin