Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

Makefile: Fix make up_c to work with tags #6

Closed
dumbbell opened this issue Mar 12, 2015 · 1 comment
Closed

Makefile: Fix make up_c to work with tags #6

dumbbell opened this issue Mar 12, 2015 · 1 comment
Assignees
@dumbbell
Labels
bug effort-tiny
Milestone
3.5.1

Comments

@dumbbell
Copy link
Member

When issueing make up_c BRANCH=rabbitmq_v3_5_0 for instance, the tag is checked out but the next git pull --ff-only fails because the checkout is detached from HEAD (which is expected).

The same would happen if one wanted to checkout a remote branch (as opposed to a local one).

When detached from HEAD, we shouldn't try to pull and update the checkout.
@dumbbell dumbbell self-assigned this Mar 12, 2015
@dumbbell dumbbell mentioned this issue Mar 12, 2015
Merged
dumbbell added a commit that referenced this issue Mar 12, 2015
@dumbbell
Merge pull request #11 from #6
aa403c0 
Makefile: Fix "make up_c" with detached HEAD
@dumbbell dumbbell modified the milestone: 3.5.1 Mar 13, 2015
@dumbbell dumbbell added the bug label Mar 13, 2015
@dumbbell
Copy link
Member Author

dumbbell commented Apr 1, 2015

Since 3.5.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dumbbell dumbbell

Labels
bug effort-tiny
Projects
None yet
Milestone
3.5.1
Development

No branches or pull requests
1 participant
@dumbbell