CLI commands do not scan [for commands] plugins that are transient dependencies

[Gsantomaggio]

The command fails in two different contexts.

New installation

• execute a docker image

docker run -it --name rmq311 --rm \
                 -p 5672:5672 -p 15672:15672 \
                rabbitmq:3.11-management

• enter to the docker image:

docker exec -it rmq311      /bin/bash

• enable the plugin in this way:

rabbitmq-plugins enable rabbitmq_stream_management

• try to execute the command:

rabbitmq-streams add_super_stream invoices --partitions 3

Command 'add_super_stream' not found.

It works only if the rabbitmq_stream plugin is enabled first and then it is possible to enable rabbitmq_stream_management

Update cluster

I had a similar problem during a cluster update from 3.10.7 to 3.11
I tried to execute:

rabbitmq-streams add_super_stream test --partitions 3

Command 'add_super_stream' not found.

I had to remove and enable the plugin to make it working:

### disable the plugin
root@node0:~> rabbitmq-plugins disable rabbitmq_stream
Disabling plugins on node rabbit@node0:
rabbitmq_stream
The following plugins have been configured:
  rabbitmq_management
  rabbitmq_management_agent
  rabbitmq_top
  rabbitmq_web_dispatch
Applying plugin configuration to rabbit@node0...
The following plugins have been disabled:
  rabbitmq_stream
  rabbitmq_stream_management

stopped 2 plugins.

### enable  it again
root@node0:~> rabbitmq-plugins enable  rabbitmq_stream
Enabling plugins on node rabbit@node0:
rabbitmq_stream
The following plugins have been configured:
  rabbitmq_management
  rabbitmq_management_agent
  rabbitmq_stream
  rabbitmq_top
  rabbitmq_web_dispatch
Applying plugin configuration to rabbit@node0...
The following plugins have been enabled:
  rabbitmq_stream

started 1 plugins.

### it works here 
root@node0:~> rabbitmq-streams add_super_stream test --partitions 3
Adding a super stream...
Super stream test has been created

[Gsantomaggio]

how to reproduce

$ bazel run broker RABBITMQ_ENABLED_PLUGINS=rabbitmq_stream_management

then

$ ./bazel-bin/broker-home/sbin/rabbitmq-streams add_super_stream test --partitions 3

Command 'add_super_stream' not found.

Problem

The Cli uses the enabled_plugins file to understand the plugin commands through implements_command_behaviour

rabbitmq-server/deps/rabbitmq_cli/lib/rabbitmq/cli/core/command_modules.ex

Lines 103 to 115 in 97a756e

	defp make_module_map(modules, scope) when modules != nil do
	commands_ns = Regex.recompile!(@commands_ns)
	modules
	|> Enum.filter(fn mod ->
	to_string(mod) =~ commands_ns and
	module_exists?(mod) and
	implements_command_behaviour?(mod) and
	command_in_scope(mod, scope)
	end)
	|> Enum.map(&command_tuple/1)
	|> Map.new()
	end

When the stream is enabled using rabbitmq-plugin enable rabbitmq_stream_management inside the enabled_plugins there is only [rabbitmq_stream_management].

That's why the rabbitmq_stream commands are not loaded.

This error also happens with rabbitmq_shovel_management and rabbitmq_federation_management

[Gsantomaggio]

One of the possible solutions could be:

• query the node to ask the actual running plugins
• fall back to the file if the node is down

It could be a change without too much impact

per conversation with @dumbbell

[SimonUnge]

Started looking into this issue, with a solution that does not require communication with a running node (via RPC), but instead include a plugins dependencies in the verification.